Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring query-frontend interface names with loopback device #4586

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Configuring query-frontend interface names with loopback device #4586

merged 3 commits into from
Oct 29, 2021

Conversation

dannykopping
Copy link
Contributor

What this PR does / why we need it:
Extending from #4570, this also sets the interface name for the v2 query-frontend.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Without this, I'm getting this error on main:

level=warn ts=2021-10-29T05:58:17.776087013Z caller=net.go:19 msg="error getting interface" inf=eth0 err="route ip+net: no such network interface"
level=warn ts=2021-10-29T05:58:17.776552383Z caller=net.go:19 msg="error getting interface" inf=en0 err="route ip+net: no such network interface"
level=error ts=2021-10-29T05:58:17.776747007Z caller=log.go:106 msg="error running loki" err="No address found for [eth0 en0]\nfailed to get frontend address\ngit.luolix.top/grafana/loki/pkg/lokifrontend/frontend.InitFrontend\

Checklist

  • Documentation added
  • Tests updated

Danny Kopping added 2 commits October 29, 2021 15:38
Configuring query-frontend interface names with loopback device
5b2684b 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Adding test (thanks @DylanGuedes!)
1c38089 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Appeasing the linter
d22b4e3 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping marked this pull request as ready for review October 29, 2021 14:06
@dannykopping dannykopping requested a review from a team as a code owner October 29, 2021 14:06
@dannykopping dannykopping merged commit de7ab3f into grafana:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannykopping @owen-d